Improve logging

src/features/game_networking.rs

@@ -46,6 +46,7 @@ impl GameNetworking {
         firewall: &Firewall,
     ) -> Result<(), Box<dyn Error>> {
         let Some(exe_path) = system_info.get_game_exe_path() else {
+            log::warn!("Unable to find game executable path.");
             return Ok(());
         };
         firewall

src/gui/run.rs

@@ -12,8 +12,8 @@ fn app_creator(
     cc: &eframe::CreationContext<'_>,
 ) -> Result<Box<dyn eframe::App>, Box<dyn std::error::Error + Send + Sync>> {
     // initialize COM just in case
-    if unsafe { CoInitializeEx(None, COINIT_APARTMENTTHREADED) }.is_err() {
+    if let Err(e) = unsafe { CoInitializeEx(None, COINIT_APARTMENTTHREADED) }.ok() {
-        log::error!("couldn't initialize COM");
+        log::error!("couldn't initialize COM: {e}");
     }
     // initialize App early to modify some things before returning it
     let mut app = Box::new(App::default());

src/util/firewall.rs

@@ -32,14 +32,16 @@ impl Firewall {
         direction: RuleDirection,
         protocol: RuleProtocol,
     ) -> Result<(), Box<dyn Error>> {
+        let add_rule = || {
             let rules = unsafe { self.policy.Rules() }?;
             unsafe { rules.Remove(&BSTR::from(name)) }?;
-        let rule: INetFwRule = unsafe { CoCreateInstance(&NetFwRule, None, CLSCTX_INPROC_SERVER) }?;
+            let rule: INetFwRule =
+                unsafe { CoCreateInstance(&NetFwRule, None, CLSCTX_INPROC_SERVER) }?;
             unsafe { rule.SetName(&BSTR::from(name)) }?;
             match mode {
-            RuleMode::Executable(exe) => {
+                RuleMode::Executable(exe) => unsafe {
-                unsafe { rule.SetApplicationName(&BSTR::from(exe.to_string_lossy().to_string())) }?
+                    rule.SetApplicationName(&BSTR::from(exe.to_string_lossy().to_string()))
-            }
+                }?,
                 RuleMode::Address(ip) => unsafe { rule.SetRemoteAddresses(&BSTR::from(ip)) }?,
             }
             match direction {
@@ -55,12 +57,17 @@ impl Firewall {
             }
             unsafe { rules.Add(&rule) }?;
             Ok(())
+        };
+        add_rule().inspect_err(|e| log::warn!("Failed to add rule '{name}': {e}"))
     }
 
     pub fn remove(&self, name: &str) -> Result<(), Box<dyn Error>> {
+        let remove_rule = || {
             let rules = unsafe { self.policy.Rules() }?;
             unsafe { rules.Remove(&BSTR::from(name)) }?;
             Ok(())
+        };
+        remove_rule().inspect_err(|e| log::warn!("Failed to remove rule '{name}': {e}"))
     }
 
     pub fn is_blocked(&self, name: &str) -> Result<bool, Box<dyn Error>> {