From 9b5340a6c57432e1712bf70bee4b9bb932ead3c9 Mon Sep 17 00:00:00 2001
From: futile <git@futile.eu>
Date: Fri, 21 Nov 2025 11:19:24 +0000
Subject: [PATCH] apply clippy suggestions

---
 src/features/game_networking.rs | 6 +++---
 src/gui/app.rs                  | 2 +-
 src/main.rs                     | 4 +++-
 src/util/logging.rs             | 2 +-
 4 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/src/features/game_networking.rs b/src/features/game_networking.rs
index 1a9c4b3..c9164e2 100644
--- a/src/features/game_networking.rs
+++ b/src/features/game_networking.rs
@@ -58,7 +58,7 @@ pub struct GameNetworking {
 impl Default for GameNetworking {
     fn default() -> Self {
         Self {
-            blocked_status: if Self::is_save_server_blocked().unwrap() == true {
+            blocked_status: if Self::is_save_server_blocked().unwrap() {
                 Self::is_save_server_blocked().unwrap().into()
             } else {
                 Self::is_exe_blocked().unwrap().into()
@@ -84,7 +84,7 @@ enum Mode {
 }
 
 impl GameNetworking {
-    fn block_generic(&mut self, mode: Mode) -> Result<(), Box<dyn Error>> {
+    fn block_generic(&self, mode: Mode) -> Result<(), Box<dyn Error>> {
         let policy: INetFwPolicy2 =
             unsafe { CoCreateInstance(&NetFwPolicy2, None, CLSCTX_INPROC_SERVER) }?;
         let rules = unsafe { policy.Rules() }?;
@@ -108,7 +108,7 @@ impl GameNetworking {
         Ok(())
     }
 
-    fn unblock_generic(&mut self, filter_name: &str) -> Result<(), Box<dyn Error>> {
+    fn unblock_generic(&self, filter_name: &str) -> Result<(), Box<dyn Error>> {
         let policy: INetFwPolicy2 =
             unsafe { CoCreateInstance(&NetFwPolicy2, None, CLSCTX_INPROC_SERVER) }?;
         let rules = unsafe { policy.Rules() }?;
diff --git a/src/gui/app.rs b/src/gui/app.rs
index 6d165c6..b465312 100644
--- a/src/gui/app.rs
+++ b/src/gui/app.rs
@@ -268,7 +268,7 @@ impl App {
                             ui.label("Save server IP");
                             if ui.button("↺").clicked() {
                                 self.settings.save_server_ip = String::from(ROCKSTAR_SAVE_SERVER);
-                            };
+                            }
                         },
                     );
                 });
diff --git a/src/main.rs b/src/main.rs
index e9c69e6..544ef06 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -4,6 +4,8 @@ mod features;
 mod gui;
 mod util;
 
+use std::fmt::Write;
+
 fn init_storage() {
     if !util::consts::path::APP_STORAGE.exists() {
         std::fs::create_dir_all(util::consts::path::APP_STORAGE.as_path()).unwrap();
@@ -14,7 +16,7 @@ fn panic_hook(panic_info: &std::panic::PanicHookInfo<'_>) {
     let backtrace = std::backtrace::Backtrace::capture();
     let mut message = format!("{panic_info}");
     if backtrace.status() == std::backtrace::BacktraceStatus::Captured {
-        message += &format!("\nstack backtrace:\n{backtrace}");
+        write!(message, "\nstack backtrace:\n{backtrace}").unwrap();
     }
     log::error!("{message}");
 }
diff --git a/src/util/logging.rs b/src/util/logging.rs
index 6064313..3647c00 100644
--- a/src/util/logging.rs
+++ b/src/util/logging.rs
@@ -59,6 +59,6 @@ impl Logger {
             humantime::format_rfc3339_seconds(SystemTime::now()),
             record.level(),
             record.args()
-        )
+        );
     }
 }