apply (some) clippy suggestions

This commit is contained in:
2025-12-11 02:44:40 +00:00
parent b0afa9de1a
commit fb7e1f7864
3 changed files with 10 additions and 10 deletions
+6 -6
View File
@@ -59,7 +59,7 @@ enum Mode {
} }
impl GameNetworking { impl GameNetworking {
fn block_generic(&self, mode: Mode) -> Result<(), Box<dyn Error>> { fn block_generic(mode: Mode) -> Result<(), Box<dyn Error>> {
let policy: INetFwPolicy2 = let policy: INetFwPolicy2 =
unsafe { CoCreateInstance(&NetFwPolicy2, None, CLSCTX_INPROC_SERVER) }?; unsafe { CoCreateInstance(&NetFwPolicy2, None, CLSCTX_INPROC_SERVER) }?;
let rules = unsafe { policy.Rules() }?; let rules = unsafe { policy.Rules() }?;
@@ -87,7 +87,7 @@ impl GameNetworking {
Ok(()) Ok(())
} }
fn unblock_generic(&self, filter_name: &str) -> Result<(), Box<dyn Error>> { fn unblock_generic(filter_name: &str) -> Result<(), Box<dyn Error>> {
let policy: INetFwPolicy2 = let policy: INetFwPolicy2 =
unsafe { CoCreateInstance(&NetFwPolicy2, None, CLSCTX_INPROC_SERVER) }?; unsafe { CoCreateInstance(&NetFwPolicy2, None, CLSCTX_INPROC_SERVER) }?;
let rules = unsafe { policy.Rules() }?; let rules = unsafe { policy.Rules() }?;
@@ -107,13 +107,13 @@ impl GameNetworking {
let Some(exe_path) = get_game_exe_path(system_info) else { let Some(exe_path) = get_game_exe_path(system_info) else {
return Ok(()); return Ok(());
}; };
self.block_generic(Mode::EntireGame(exe_path.to_path_buf()))?; Self::block_generic(Mode::EntireGame(exe_path.to_path_buf()))?;
self.blocked = Self::is_exe_blocked()?; self.blocked = Self::is_exe_blocked()?;
Ok(()) Ok(())
} }
pub fn unblock_exe(&mut self) -> Result<(), Box<dyn Error>> { pub fn unblock_exe(&mut self) -> Result<(), Box<dyn Error>> {
self.unblock_generic(FILTER_NAME_EXE)?; Self::unblock_generic(FILTER_NAME_EXE)?;
self.blocked = Self::is_exe_blocked()?; self.blocked = Self::is_exe_blocked()?;
Ok(()) Ok(())
} }
@@ -123,13 +123,13 @@ impl GameNetworking {
} }
pub fn block_save_server(&mut self, save_server_ip: &str) -> Result<(), Box<dyn Error>> { pub fn block_save_server(&mut self, save_server_ip: &str) -> Result<(), Box<dyn Error>> {
self.block_generic(Mode::SaveServer(save_server_ip.to_owned()))?; Self::block_generic(Mode::SaveServer(save_server_ip.to_owned()))?;
self.blocked = Self::is_save_server_blocked()?; self.blocked = Self::is_save_server_blocked()?;
Ok(()) Ok(())
} }
pub fn unblock_save_server(&mut self) -> Result<(), Box<dyn Error>> { pub fn unblock_save_server(&mut self) -> Result<(), Box<dyn Error>> {
self.unblock_generic(FILTER_NAME_SAVE_SERVER)?; Self::unblock_generic(FILTER_NAME_SAVE_SERVER)?;
self.blocked = Self::is_save_server_blocked()?; self.blocked = Self::is_save_server_blocked()?;
Ok(()) Ok(())
} }
+2 -2
View File
@@ -206,7 +206,7 @@ impl App {
} }
} }
}); });
}) });
}, },
); );
}) })
@@ -261,7 +261,7 @@ impl App {
.ensure_block_exclusivity(self.settings.block_method) .ensure_block_exclusivity(self.settings.block_method)
{ {
log::warn!("Couldn't ensure block exclusivity: {why}"); log::warn!("Couldn't ensure block exclusivity: {why}");
}; }
}); });
if self.settings.block_method == BlockMethod::SaveServer { if self.settings.block_method == BlockMethod::SaveServer {
ui.horizontal(|ui| { ui.horizontal(|ui| {
+2 -2
View File
@@ -27,7 +27,7 @@ impl log::Log for Logger {
fn log(&self, record: &log::Record) { fn log(&self, record: &log::Record) {
if self.enabled(record.metadata()) { if self.enabled(record.metadata()) {
self.log_to_stderr(record); Self::log_to_stderr(record);
self.log_to_file(record); self.log_to_file(record);
} }
} }
@@ -53,7 +53,7 @@ impl Logger {
file.flush().unwrap(); file.flush().unwrap();
} }
fn log_to_stderr(&self, record: &log::Record) { fn log_to_stderr(record: &log::Record) {
eprintln!( eprintln!(
"[{}][{}]\n{}", "[{}][{}]\n{}",
humantime::format_rfc3339_seconds(SystemTime::now()), humantime::format_rfc3339_seconds(SystemTime::now()),