fix a multitude of clippy warns

src/process/handle.rs

@@ -8,6 +8,9 @@ use windows::Win32::System::Threading::{
 #[derive(Debug, Default, Clone)]
 pub struct Handle(pub HANDLE);
 
+unsafe impl Send for Handle {}
+unsafe impl Sync for Handle {}
+
 impl Deref for Handle {
     type Target = HANDLE;
 

src/process/memory.rs

@@ -1,51 +1,39 @@
 use super::handle::Handle;
 
-use std::ffi::c_void;
+use std::{ffi::c_void, ptr};
 
 use windows::Win32::System::Diagnostics::Debug::{ReadProcessMemory, WriteProcessMemory};
 
-pub fn read_process_memory<T>(
+pub fn read<T>(handle: &Handle, address: usize, value: &mut T) -> Result<(), crate::Error> {
-    handle: &Handle,
-    address: usize,
-    value: &mut T,
-) -> Result<(), crate::Error> {
     unsafe {
         match ReadProcessMemory(
             handle.0,
             address as *const c_void,
-            value as *mut T as *mut c_void,
+            (ptr::from_mut::<T>(value)).cast::<c_void>(),
             size_of::<T>(),
             None,
         ) {
-            Ok(()) => return Ok(()),
+            Ok(()) => Ok(()),
-            Err(why) => {
+            Err(why) => Err(crate::Error::MemoryError(format!(
-                return Err(crate::Error::MemoryError(format!(
                 "failed to read memory: {why}"
-                )));
+            ))),
         }
-        };
     }
 }
 
-pub fn write_process_memory<T>(
+pub fn write<T>(handle: &Handle, address: usize, value: &mut T) -> Result<(), crate::Error> {
-    handle: &Handle,
-    address: usize,
-    value: &mut T,
-) -> Result<(), crate::Error> {
     unsafe {
         match WriteProcessMemory(
             handle.0,
             address as *const c_void,
-            value as *mut T as *mut c_void,
+            (ptr::from_mut::<T>(value)).cast::<c_void>(),
             size_of::<T>(),
             None,
         ) {
-            Ok(()) => return Ok(()),
+            Ok(()) => Ok(()),
-            Err(why) => {
+            Err(why) => Err(crate::Error::MemoryError(format!(
-                return Err(crate::Error::MemoryError(format!(
                 "failed to write memory: {why}"
-                )));
+            ))),
         }
-        };
     }
 }

src/process/mod.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::module_inception)]
+
 mod handle;
 mod memory;
 mod process;

src/process/process.rs

@@ -1,8 +1,4 @@
-use super::{
+use super::{handle::Handle, memory, snapshot};
-    handle::Handle,
-    memory::{read_process_memory, write_process_memory},
-    snapshot,
-};
 
 use derive_more::derive::Display;
 
@@ -70,7 +66,7 @@ impl Process {
 
     pub fn read_mem<T: Default>(&self, address: usize) -> Result<T, crate::Error> {
         let mut value = Default::default();
-        read_process_memory(&self.handle, address, &mut value)?;
+        memory::read(&self.handle, address, &mut value)?;
         Ok(value)
     }
 
@@ -96,7 +92,7 @@ impl Process {
     }
 
     pub fn write_mem<T: Default>(&self, address: usize, mut value: T) -> Result<(), crate::Error> {
-        write_process_memory(&self.handle, address, &mut value)?;
+        memory::write(&self.handle, address, &mut value)?;
         Ok(())
     }
 }

src/process/snapshot.rs

@@ -98,7 +98,7 @@ impl Module {
             let path = String::from_utf16_lossy(&module_entry_32_w.szExePath)
                 .trim_end_matches('\0')
                 .to_string();
-            let module = Module {
+            let module = Self {
                 process_id: pid,
                 name,
                 path,