From 99db8bcd72eb61c0f2f4e70a86eee38010d2eb26 Mon Sep 17 00:00:00 2001 From: futile Date: Wed, 3 Dec 2025 12:42:56 +0000 Subject: [PATCH] apply (some) clippy suggestions --- src/sys.rs | 6 +++--- src/sys/handle.rs | 2 +- src/sys/snapshot.rs | 14 +++++++------- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/sys.rs b/src/sys.rs index 82e9bd2..0320825 100644 --- a/src/sys.rs +++ b/src/sys.rs @@ -1,3 +1,3 @@ -pub(crate) mod handle; -pub(crate) mod memory; -pub(crate) mod snapshot; +pub mod handle; +pub mod memory; +pub mod snapshot; diff --git a/src/sys/handle.rs b/src/sys/handle.rs index 416fc8e..303752f 100644 --- a/src/sys/handle.rs +++ b/src/sys/handle.rs @@ -23,7 +23,7 @@ impl Drop for Handle { fn drop(&mut self) { if let Err(why) = unsafe { CloseHandle(**self) } { log::error!("failed to close handle: {why}"); - }; + } } } diff --git a/src/sys/snapshot.rs b/src/sys/snapshot.rs index 22e1c4c..f786df4 100644 --- a/src/sys/snapshot.rs +++ b/src/sys/snapshot.rs @@ -1,7 +1,7 @@ use crate::Error; use windows::Win32::System::Diagnostics::ToolHelp::{ - CreateToolhelp32Snapshot, Module32FirstW, Module32NextW, Process32FirstW, Process32NextW, - MODULEENTRY32W, PROCESSENTRY32W, TH32CS_SNAPMODULE, TH32CS_SNAPMODULE32, TH32CS_SNAPPROCESS, + CreateToolhelp32Snapshot, MODULEENTRY32W, Module32FirstW, Module32NextW, PROCESSENTRY32W, + Process32FirstW, Process32NextW, TH32CS_SNAPMODULE, TH32CS_SNAPMODULE32, TH32CS_SNAPPROCESS, }; #[derive(Debug)] @@ -20,7 +20,7 @@ impl ProcessSnapshot { dwSize: u32::try_from(size_of::())?, ..Default::default() }; - unsafe { Process32FirstW(snapshot, &mut process_entry_32_w) }.map_err(|why| { + unsafe { Process32FirstW(snapshot, &raw mut process_entry_32_w) }.map_err(|why| { Error::CreateSnapshotError(format!("failed to get first process from snapshot: {why}")) })?; let mut processes = Vec::new(); @@ -33,9 +33,9 @@ impl ProcessSnapshot { name, }; processes.push(process); - if unsafe { Process32NextW(snapshot, &mut process_entry_32_w) }.is_err() { + if unsafe { Process32NextW(snapshot, &raw mut process_entry_32_w) }.is_err() { break; - }; + } } Ok(processes) } @@ -60,7 +60,7 @@ impl ModuleSnapshot { dwSize: u32::try_from(size_of::())?, ..Default::default() }; - unsafe { Module32FirstW(snapshot, &mut module_entry_32_w) }.map_err(|why| { + unsafe { Module32FirstW(snapshot, &raw mut module_entry_32_w) }.map_err(|why| { Error::CreateSnapshotError(format!("failed to get first module from snapshot: {why}")) })?; let mut modules = Vec::new(); @@ -78,7 +78,7 @@ impl ModuleSnapshot { base_size: module_entry_32_w.modBaseSize as usize, }; modules.push(module); - if unsafe { Module32NextW(snapshot, &mut module_entry_32_w).is_err() } { + if unsafe { Module32NextW(snapshot, &raw mut module_entry_32_w).is_err() } { break; } }