From ffd8da03434754bdc6ccdf7b78bfd1e1cb2201a0 Mon Sep 17 00:00:00 2001 From: futile Date: Tue, 31 Dec 2024 08:33:11 +0000 Subject: [PATCH] add `log` and use `error!` in Drop of Handle to let users choose if they want to care about failed CloseHandle --- Cargo.toml | 1 + src/process/handle.rs | 10 ++++------ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index 2da49a2..5066c70 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -10,6 +10,7 @@ keywords = ["memory", "game", "hacking", "process"] [dependencies] derive_more = { version = "1.0.0", features = ["display"] } +log = "0.4.22" thiserror = "2.0.9" [dependencies.windows] diff --git a/src/process/handle.rs b/src/process/handle.rs index 7af0192..064b62f 100644 --- a/src/process/handle.rs +++ b/src/process/handle.rs @@ -21,12 +21,10 @@ impl Deref for Handle { impl Drop for Handle { fn drop(&mut self) { - if self.0 != INVALID_HANDLE_VALUE { - unsafe { - if let Err(why) = CloseHandle(**self) { - eprintln!("failed to close handle: {why}"); - }; - } + unsafe { + if let Err(why) = CloseHandle(**self) { + log::error!("failed to close handle: {why}"); + }; } } }